-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JupyterLab 3 support #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keller-mark I upgraded and didn't notice anything glaringly wrong. I did have an issue where going back and forth between different configs with scatterplots where they did not display after closing the first widget but I seriously doubt that is related. I tried downgrading (i.e reverting the environment) for this PR but got an error when trying to install/uninstall
jupyter labextension install @jupyter-widgets/jupyterlab-manager
but I'm not sure this is relevant. Can you reproduce this issue either on an earlier release or now?
Alternatively, could you provide directions for reverting the changes to this environment? |
How to start a fresh environment to try to A) reproduce the original issue with JupyterLab 3 and B) test whether the changes in this PR fix it. conda deactivate
conda env remove -n vitessce-jupyter-examples A. git checkout master
# in docs/notebooks
conda env create -f environment.yml
conda install -c conda-forge jupyterlab>=3.0.0
conda list Check that the version of JupyterLab is greater than 3.0.0
before trying part B, delete the environment again conda deactivate
conda env remove -n vitessce-jupyter-examples B. git checkout keller-mark/jupyterlab-3
# in docs/notebooks
conda env create -f environment.yml
conda list Check that the version of JupyterLab is greater than 3.0.0
|
Ok @keller-mark looks like the issue I saw doesn't have to do with this so this looks good to me. I'll file an issue here about it although not sure it's a |
Opened: #68 |
Fixes #37 . JupyterLab 3 uses React
^17.0.1
, while earlier versions depended on React~16.9.0
This also adds a section to the docs which lists the jupyterlab and jupyter notebook versions which are compatible with the widget.