Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing Json_arrayagg and Json_objectagg to allow some queries to work #16251

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

GuptaManan100
Copy link
Member

Description

This PR fixes the issue described in #16250. As pointed out in the issue, the problem is coming because we don't explicitly parse the two constructs. This PR fixes this problem by adding explicit parsing support for both of them and making them implement the AggrFunc interface to allow the planner to know that these are aggregation functions. End to end tests have been added to verify that the case described in the issue work as intended after the changes in this PR.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Manan Gupta <manan@planetscale.com>
…add tests

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Copy link
Contributor

vitess-bot bot commented Jun 24, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 24, 2024
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jun 24, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 68.61%. Comparing base (7a737f4) to head (4db4343).
Report is 8 commits behind head on main.

Files Patch % Lines
go/vt/sqlparser/ast.go 11.76% 15 Missing ⚠️
go/vt/sqlparser/ast_format.go 37.50% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16251   +/-   ##
=======================================
  Coverage   68.61%   68.61%           
=======================================
  Files        1544     1544           
  Lines      197993   198016   +23     
=======================================
+ Hits       135848   135869   +21     
- Misses      62145    62147    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a negative plan test for it?

…gation expression is required to be evaluated at the vtgate

Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 merged commit fbbd036 into vitessio:main Jun 25, 2024
94 checks passed
@GuptaManan100 GuptaManan100 deleted the parsing-json-aggregation branch June 25, 2024 10:48
systay pushed a commit that referenced this pull request Jul 22, 2024
… work (#16251) (#5477)

Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Json_ArrayAgg and Json_ObjectAgg not working in having clause
3 participants