-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing Json_arrayagg
and Json_objectagg
to allow some queries to work
#16251
Parsing Json_arrayagg
and Json_objectagg
to allow some queries to work
#16251
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
…add tests Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16251 +/- ##
=======================================
Coverage 68.61% 68.61%
=======================================
Files 1544 1544
Lines 197993 198016 +23
=======================================
+ Hits 135848 135869 +21
- Misses 62145 62147 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a negative plan test for it?
…gation expression is required to be evaluated at the vtgate Signed-off-by: Manan Gupta <manan@planetscale.com>
Description
This PR fixes the issue described in #16250. As pointed out in the issue, the problem is coming because we don't explicitly parse the two constructs. This PR fixes this problem by adding explicit parsing support for both of them and making them implement the AggrFunc interface to allow the planner to know that these are aggregation functions. End to end tests have been added to verify that the case described in the issue work as intended after the changes in this PR.
Related Issue(s)
Checklist
Deployment Notes