Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the gen4 planner for queries with outer joins #9657

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

systay
Copy link
Collaborator

@systay systay commented Feb 9, 2022

Description

Routing for queries that contain outer join was not being handled correctly.
It would require a lot of changes to support these queries correctly in V3, so instead this fix makes it so the gen4 planner is used in the presence of outer joins.

If you know that you want to use the v3 planner, that can still be accomplished by using the query hint /*vt+ PLANNER=v3 */

Related Issue(s)

Fixes #7700

@systay systay changed the title fix: use the gen4 planner for queries with outer joins Use the gen4 planner for queries with outer joins Feb 9, 2022
@systay
Copy link
Collaborator Author

systay commented Feb 9, 2022

Ping @arthurschreiber

@systay systay force-pushed the outer-join-planning-bug branch 2 times, most recently from 5db2b45 to 4b696a0 Compare February 10, 2022 08:56
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit 208d8ce into vitessio:main Feb 11, 2022
@systay systay deleted the outer-join-planning-bug branch February 11, 2022 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

left join query does not produce correct results when filtering on sharding key with is null
2 participants