Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the gen4 planner for queries with outer joins #9671

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

systay
Copy link
Collaborator

@systay systay commented Feb 11, 2022

Routing for queries that contain outer join was not being handled correctly.
It would require a lot of changes to support these queries correctly in V3, so instead this fix makes it so the gen4 planner is used in the presence of outer joins.

If you know that you want to use the v3 planner, that can still be accomplished by using the query hint /*vt+ PLANNER=v3 */

Related Issue(s)

Fixes #7700
Backport of #9657

Signed-off-by: Andres Taylor <andres@planetscale.com>
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@systay - is there a reason why 22c7bca was not cherry-picked?

@systay
Copy link
Collaborator Author

systay commented Feb 14, 2022

@systay - is there a reason why 22c7bca was not cherry-picked?

Yeah, the second commit was pure optimization, not a bug fix per se.

@frouioui
Copy link
Member

@systay - Gotcha, thanks!

@systay systay merged commit 3ded3eb into vitessio:release-13.0 Feb 15, 2022
@systay systay deleted the 9657-backport-to-13 branch February 15, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants