Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add task tests iteratively #5235

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

DerYeger
Copy link
Member

@DerYeger DerYeger commented Feb 19, 2024

Closes #5234. The spread operator may result in an exceeded stack size limit for a very large number of tests.

Description

See #5234, a very large number of tests results in an exceeded stack size limit due to the usage of the spread operator.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 172b086
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65d46d4cdfbc420008e4d7a3
😎 Deploy Preview https://deploy-preview-5235--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DerYeger
Copy link
Member Author

I'll fix the checks and add the changeset soon. Slow train internet won't let me install the dependencies.

@DerYeger
Copy link
Member Author

lint is now green. Based on the 404ed Chrome driver, I assume the failing tests are not related to my change(s).

@hi-ogawa
Copy link
Contributor

hi-ogawa commented Feb 20, 2024

Maybe this one too? (though UI might not be usable if there are that much of test cases...)

tests.push(...getTests(task))

(btw, chrome driver issue will be fixed in #5240)

@DerYeger
Copy link
Member Author

DerYeger commented Feb 20, 2024

Maybe this one too? (though UI might not be usable if there are that much of test cases...)

tests.push(...getTests(task))

(btw, chrome driver issue will be fixed in #5240)

Good call! I've changed that part as well, just to be safe.

@DerYeger DerYeger force-pushed the patch-1 branch 2 times, most recently from 7414afc to 6240415 Compare February 20, 2024 09:09
The spread operator may result in an exceeded stack size limit for a very large number of tests.
@sheremet-va sheremet-va merged commit 3815554 into vitest-dev:main Feb 20, 2024
19 checks passed
@DerYeger DerYeger deleted the patch-1 branch February 20, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collector fails with very large test counts (>> 100000)
3 participants