Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use startVitest instead of execa #5439

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Mar 27, 2024

Description

Attempts to fix flaky CI. Replaces usage of runVitestCli() with lighter runVitest() utility. This reduces the amount of node:child_process launched during tests (via execa). The runVitestCli() should only be used when tests require interactive watch mode or are explicitly testing CLI options.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 6fb6844
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/660916ef153ab20008685f27
😎 Deploy Preview https://deploy-preview-5439--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AriPerkkio AriPerkkio force-pushed the ci/concurrency branch 5 times, most recently from 034d711 to b882bea Compare March 31, 2024 07:14
@AriPerkkio AriPerkkio changed the title ci: set workspace-concurrency to 2 test: use startVitest instead of execa Mar 31, 2024
@AriPerkkio AriPerkkio marked this pull request as ready for review March 31, 2024 08:10
@sheremet-va sheremet-va merged commit 2a8e2fb into vitest-dev:main Mar 31, 2024
19 checks passed
@AriPerkkio AriPerkkio deleted the ci/concurrency branch March 31, 2024 09:13
@hi-ogawa
Copy link
Contributor

hi-ogawa commented Apr 1, 2024

Nice, thanks a lot!

@AriPerkkio AriPerkkio mentioned this pull request Apr 1, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants