-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specification of metadata to be fetched for Websocket Queries #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanheller
force-pushed
the
feature/md-spec-166
branch
from
November 18, 2021 18:28
6574d8d
to
fdbc53d
Compare
sauterl
requested changes
Nov 18, 2021
cineast-api/src/main/java/org/vitrivr/cineast/api/messages/query/TemporalQuery.java
Outdated
Show resolved
Hide resolved
cineast-api/src/main/java/org/vitrivr/cineast/api/messages/query/TemporalQuery.java
Outdated
Show resolved
Hide resolved
...ain/java/org/vitrivr/cineast/api/websocket/handlers/queries/AbstractQueryMessageHandler.java
Outdated
Show resolved
Hide resolved
...ain/java/org/vitrivr/cineast/api/websocket/handlers/queries/AbstractQueryMessageHandler.java
Outdated
Show resolved
Hide resolved
...ain/java/org/vitrivr/cineast/api/websocket/handlers/queries/AbstractQueryMessageHandler.java
Outdated
Show resolved
Hide resolved
...ain/java/org/vitrivr/cineast/api/websocket/handlers/queries/AbstractQueryMessageHandler.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/org/vitrivr/cineast/core/data/entities/MediaObjectMetadataDescriptor.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/org/vitrivr/cineast/core/data/entities/MediaSegmentMetadataDescriptor.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/org/vitrivr/cineast/core/data/entities/MediaSegmentMetadataDescriptor.java
Outdated
Show resolved
Hide resolved
cineast-core/src/main/java/org/vitrivr/cineast/core/util/CineastConstants.java
Show resolved
Hide resolved
Generally speaking I like this PR very much, there are a few minor engineering points I think are to be improved. |
…eader / writer for unit-tests
silvanheller
force-pushed
the
feature/md-spec-166
branch
from
December 2, 2021 09:20
fdbc53d
to
2889c1c
Compare
sauterl
approved these changes
Dec 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @silvanheller for the PR
silvanheller
added a commit
that referenced
this pull request
Jun 10, 2022
Allow specification of metadata to be fetched for Websocket Queries Former-commit-id: 6037f63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
MetadataAccessSpecification
, of which a list can be handed to Cineast.*
for either domain or keys mean all elements should be fetched. For backwards-compatibility,null
is treated as*
,*
, which means all metadata is fetched.Implementation is unit-tested.
Closes #166
As a simple comparison, on the LSC 21 dataset, this reduces metadata fetch time for a tag query
sushi_bar
(5k results) from approx. 2.5 to 2 seconds:(old)
(new)
For larger result-sets (i.e. hitting the config limit, currently 20k) it goes from 9.4 to 6 seconds + there are (obviously) gains in serialization speed.
(old)
(new)