Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed maven plugin #253

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Removed maven plugin #253

merged 2 commits into from
Feb 11, 2022

Conversation

Spiess
Copy link
Member

@Spiess Spiess commented Feb 4, 2022

Removed maven plugin, possibly fixing #208 and added @Spiess as developer to publish task.

@silvanheller
Copy link
Member

Well I think we probably want to have an alternative publishing system, no?

@Spiess
Copy link
Member Author

Spiess commented Feb 4, 2022

There is already a replacement publishing system in place with maven-publish.
As far as I can tell, the maven plugin no longer exists and caused the publishing process to fail, but I will need to find a way to test this locally to confirm.

@silvanheller
Copy link
Member

So gradle publish should simply use maven-publish automatically?

@Spiess
Copy link
Member Author

Spiess commented Feb 4, 2022

That appears to be the case for the Cottontail DB Proto repo at least, but maybe @ppanopticon has further insight.

@Spiess Spiess marked this pull request as ready for review February 11, 2022 07:48
@Spiess
Copy link
Member Author

Spiess commented Feb 11, 2022

I have tested and confirmed the fix through publish to local maven cache.

Copy link
Member

@ppanopticon ppanopticon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ppanopticon ppanopticon merged commit 056d354 into master Feb 11, 2022
@Spiess Spiess deleted the fix/publish branch February 11, 2022 11:29
@Spiess Spiess mentioned this pull request Feb 11, 2022
silvanheller pushed a commit that referenced this pull request Jun 10, 2022
Removed maven plugin

Former-commit-id: 056d354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants