Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vivliostyle-print): images with width and height specified may dissapear in print #1340

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix(vivliostyle-print): images with width and height specified may dissapear in print #1340

merged 1 commit into from
Jun 4, 2024

Conversation

MurakamiShinyu
Copy link
Member

@vercel Vercel
Copy link

vercel bot commented Jun 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vivliostyle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 7:13am

@MurakamiShinyu MurakamiShinyu mentioned this pull request Jun 2, 2024
Closed
@MurakamiShinyu MurakamiShinyu changed the title fix: images with width and height specified may dissapear in print fix(vivliostyle-print): images with width and height specified may dissapear in print Jun 3, 2024
@MurakamiShinyu
Copy link
Member Author

I withdrew the first fix (1c5675e) and made the new fix (46699a2).

This issue occurs in vivliostyle-prinit (issue: vivliostyle/vivliostyle-print#11), but not in Vivliostyle Viewer or Vivliostyle CLI. The first fix (1c5675e) is not very good because it always adds extra processing of waiting image loading, which is unnecessary for Vivliostyle Viewer or Vivliostyle CLI.

@MurakamiShinyu MurakamiShinyu marked this pull request as draft June 3, 2024 13:41
@MurakamiShinyu
Copy link
Member Author

It still does not work. Further fix is needed.

@MurakamiShinyu
Copy link
Member Author

MurakamiShinyu commented Jun 4, 2024 •
edited
Loading

I restored the first fix with minor adjustment (985095f), because the second fix attempt (46699a2) was not successful, where I tried to activate the waitForLoading feature implemented in the old Vivliostyle.js code derived from adaptive-layout:

https://github.com/sorotokin/adaptive-layout/blob/master/js/adapt/viewer.js#L222-L224

This was only for the current viewing page, not for all pages, because the original adaptive-layout was for viewing, not for printing.

@MurakamiShinyu MurakamiShinyu marked this pull request as ready for review June 4, 2024 07:51
@MurakamiShinyu MurakamiShinyu merged commit 8823eb0 into master Jun 4, 2024
5 checks passed
@MurakamiShinyu MurakamiShinyu deleted the fix/issue1321 branch June 4, 2024 08:03
@MurakamiShinyu MurakamiShinyu mentioned this pull request Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There may be a problem with print
1 participant
@MurakamiShinyu