Skip to content

Conversation

DaltheCow
Copy link
Collaborator

Summary

The Metrics summary section now includes the data point dots on the line and a tooltip including the strategy label, e.g.: synchronous, constant@32.32, concurrent@5

Test Plan

  • Unit test for backend change
  • No tests written to check on tooltip addition, seems overflow complex to try and hover the dots on the chart but I didn't look into it.

Related Issues


  • "I certify that all code in this PR is my own."

Signed-off-by: dalthecow <dalcowboiz@gmail.com>
@DaltheCow DaltheCow added the UI Front-end workstream label Oct 7, 2025
@DaltheCow DaltheCow changed the title add dots with tooltip to line chart Features/add tooltip to line chart Oct 7, 2025
Copy link

github-actions bot commented Oct 7, 2025

🎉 Live Preview: Click here to view the live version
Last updated: aeee768

github-actions bot pushed a commit that referenced this pull request Oct 7, 2025
@ivanbaldo
Copy link

Maybe it would be useful to add also the actual value?

For example "constant@26.81 1454.62 ms" (in the TTFT graph), "constant@26.81 204.35 tok/s" (in the Throughput graph), etc..

Signed-off-by: dalthecow <dalcowboiz@gmail.com>
github-actions bot pushed a commit that referenced this pull request Oct 8, 2025
Signed-off-by: dalthecow <dalcowboiz@gmail.com>
Copy link
Collaborator

@sjmonson sjmonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sjmonson added a commit that referenced this pull request Oct 10, 2025
features/ui/add-tooltip-to-metric-summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Front-end workstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants