[GuideLLM Refactor] fix util package types #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
jaredoconnell
force-pushed
the
features/refactor-fix-util-types
branch
from
a5fdee0 to
db43ccd
Compare
jaredoconnell
commented
Oct 8, 2025
| self.buffer_receive_queue = culsans.Queue[ReceiveMessageT]( | ||
| maxsize=self.max_buffer_receive_size or 0 | ||
| ) | ||
| self.tasks_lock = threading.Lock() |
There was a problem hiding this comment.
This was entirely unused. Is that a problem?
There was a problem hiding this comment.
Yeah I am guessing this is leftover from a previous version. cc: @markurtz
sjmonson
requested changes
Oct 9, 2025
| self.buffer_receive_queue = culsans.Queue[ReceiveMessageT]( | ||
| maxsize=self.max_buffer_receive_size or 0 | ||
| ) | ||
| self.tasks_lock = threading.Lock() |
There was a problem hiding this comment.
Yeah I am guessing this is leftover from a previous version. cc: @markurtz
Co-authored-by: Samuel Monson <smonson@irbash.net> Signed-off-by: Jared O'Connell <46976761+jaredoconnell@users.noreply.github.com>
sjmonson
approved these changes
Oct 9, 2025
jaredoconnell
merged commit 538c194
into
vllm-project:features/refactor/base
8 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes all type errors in the utils package. Only a few were ignored.
Details
Test Plan
Run the tests and look through the changes to make sure the logic is equivalent or better to the original code.
Use of AI
## WRITTEN BY AI ##)