Features/refactor/quality fixes #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many of the quality errors are due to using the older union style, and have appeared due to the upgrade of the minimum Python version from 3.9 to 3.10 Signed-off-by: Jared O'Connell <joconnel@redhat.com>
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
sjmonson
added a commit
that referenced
this pull request
Oct 10, 2025
features/refactor/quality-fixes
Signed-off-by: Jared O'Connell <joconnel@redhat.com>
markurtz
approved these changes
Oct 10, 2025
sjmonson
approved these changes
Oct 10, 2025
jaredoconnell
merged commit 8f6fdfa
into
vllm-project:features/refactor/base
11 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes quality errors in the code.
Details
The recent switch to Python 3.10 means that the linter can apply 3.10 specific linters, so this fixes errors that occur now that backwards compatibility is no longer required. The biggest change is the switch from explicit
Unionreferences to|.I also took advantage of the version change to use
match.Also, it appears that the
from __future__ import annotationslines are masking a lot of circular imports. So I can't remove those yet.Test Plan
Run GuideLLM as normal, make sure the tests pass, and confirm that there are no more quality errors.
Use of AI
## WRITTEN BY AI ##)