o11y: Add TTFT and TPOT histograms for SLOs #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
tao12345666333
requested review from
rootfs,
Xunzhuo and
wangchen615
as code owners
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
rootfs
reviewed
Sep 13, 2025
| // handleResponseHeaders processes the response headers | ||
| func (r *OpenAIRouter) handleResponseHeaders(_ *ext_proc.ProcessingRequest_ResponseHeaders) (*ext_proc.ProcessingResponse, error) { | ||
| func (r *OpenAIRouter) handleResponseHeaders(_ *ext_proc.ProcessingRequest_ResponseHeaders, ctx *RequestContext) (*ext_proc.ProcessingResponse, error) { | ||
| // Best-effort TTFT measurement: record on first response headers if we have a start time and model |
There was a problem hiding this comment.
for now we haven't tried streaming mode. In the buffered mode, the response from LLM has to be fully received before the response is received. If you can add an issue to track TTFT in streaming mode, that'll be great.
There was a problem hiding this comment.
#128 for tracking
rootfs
previously approved these changes
Sep 13, 2025
|
@tao12345666333 the go mod needs an update. Once the CI is green, this is ready to go. Thanks. |
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
rootfs
approved these changes
Sep 13, 2025
This was referenced Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
o11y: Add TTFT and TPOT histograms for SLOs
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #121
Release Notes: Yes/No