Skip to content

Conversation

JaredforReal
Copy link
Contributor

What type of PR is this?
docs: network tips for CN Mainlain

What this PR does / why we need it:
This guide shows exactly how to build and run in CN Mainland, using small local override files and a compose override, without modifying repo files.
It would be helpful for people living in CN Mainland, annoyed by network blocking

Signed-off-by: JaredforReal <w13431838023@gmail.com>
Copy link

netlify bot commented Sep 24, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 2c85fea
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68d40a929487110008947587
😎 Deploy Preview https://deploy-preview-208--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Sep 24, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 website

Owners: @Xunzhuo
Files changed:

  • website/docs/troubleshooting/network-tips.md
  • website/sidebars.js

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@Xunzhuo
Copy link
Member

Xunzhuo commented Sep 24, 2025

/hold i think the network issue shouldnt be documented separately in docs cc @rootfs thoughs on it?

@github-actions github-actions bot added the hold label Sep 24, 2025
@JaredforReal
Copy link
Contributor Author

/hold i think the network issue shouldnt be documented separately in docs cc @rootfs thoughs on it?

I used to write the network solution in code, and comment them with notes: "uncommented to ......", which made the PR too complicated, so I try writting a separate docs to keep code clean.

@rootfs
Copy link
Collaborator

rootfs commented Sep 24, 2025

@JaredforReal how about creating a top level triage and diagnostic section (please come up with a better name)? This will cover how to build, deploy, and maintain the router & models, benefiting SDE, MLE, and SRE. This networking tips you provided can be the first under this section.

@JaredforReal
Copy link
Contributor Author

JaredforReal commented Sep 24, 2025

@JaredforReal how about creating a top level triage and diagnostic section (please come up with a better name)? This will cover how to build, deploy, and maintain the router & models, benefiting SDE, MLE, and SRE. This networking tips you provided can be the first under this section.

@rootfs Good idea! I could create and maintain an "Operation Handbook", which includes "Network Tips for CN Users" and "Observability and Monitoring" of the project I recently working on. This can be helpful for anyone not satisfied with just "getting started", by introducing some best practices or recommended actions.
What do you think?

@rootfs
Copy link
Collaborator

rootfs commented Sep 24, 2025

@JaredforReal sgtm, @Xunzhuo wdyt?

@Xunzhuo
Copy link
Member

Xunzhuo commented Sep 24, 2025

I think let us not emphasize network issue in CN, it could be happening in anywhere else as well, my suggestion is to add an new section called troubleshooting and add this doc into it

@JaredforReal
Copy link
Contributor Author

I think let us not emphasize network issue in CN, it could be happening in anywhere else as well, my suggestion is to add an new section called troubleshooting and add this doc into it

I can get rig of "CN Mainland" kind of word, and use CN-mirror as an example when necessary.

@rootfs
Copy link
Collaborator

rootfs commented Sep 24, 2025

I think let us not emphasize network issue in CN, it could be happening in anywhere else as well, my suggestion is to add an new section called troubleshooting and add this doc into it

I can get rig of "CN Mainland" kind of word, and use CN-mirror as an example when necessary.

That'll be much better!

@Xunzhuo
Copy link
Member

Xunzhuo commented Sep 24, 2025

Cool I want to make sure it's as neutral as possible

Signed-off-by: JaredforReal <w13431838023@gmail.com>
@JaredforReal
Copy link
Contributor Author

Cool I want to make sure it's as neutral as possible

Got u. Updated and ready for another review. Thanks @Xunzhuo @rootfs

@rootfs
Copy link
Collaborator

rootfs commented Sep 24, 2025

lgtm, @Xunzhuo can you share the final thought? thanks

@JaredforReal JaredforReal changed the title docs: network tips for CN Mainlain docs: network tips Sep 24, 2025
Xunzhuo
Xunzhuo previously approved these changes Sep 24, 2025
@Xunzhuo
Copy link
Member

Xunzhuo commented Sep 24, 2025

/lgtm thanks!

@github-actions github-actions bot added the lgtm label Sep 24, 2025
Signed-off-by: JaredforReal <w13431838023@gmail.com>
@Xunzhuo Xunzhuo merged commit 0a08e67 into vllm-project:main Sep 24, 2025
9 checks passed
JaredforReal added a commit to JaredforReal/semantic-router that referenced this pull request Sep 24, 2025
@JaredforReal JaredforReal deleted the cntips branch September 24, 2025 16:36
Aias00 pushed a commit to Aias00/semantic-router that referenced this pull request Oct 4, 2025
Signed-off-by: liuhy <liuhongyu@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants