security: add security attributes related to root usage to container definitions #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rootfs
approved these changes
Sep 24, 2025
|
@fcanogab thank you for this! it looks ready to go. Can you sign the DCO |
Signed-off-by: Florencio Cano Gabarda <fcanogab@redhat.com>
fcanogab
force-pushed
the
add-security-containers
branch
from
5c3c2f1 to
5dc563a
Compare
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
|
@fcanogab Thank you for contribution! |
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
vllm-project#214) Signed-off-by: Florencio Cano Gabarda <fcanogab@redhat.com> Co-authored-by: Huamin Chen <rootfs@users.noreply.github.com> Signed-off-by: liuhy <liuhongyu@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two security attributes to container definitions that improve the security of the containers when being run in Kubernetes.
At the same time, this PR reduces the noise of vulnerabilitiy scanners because they normally raise alerts when these attributes are missing.