Skip to content

Conversation

WoosukKwon
Copy link
Collaborator

This PR adds the all_token_ids to the Request class, which is always updated with output_token_ids. Having all_token_ids can be useful because we can directly on the entire list of token ids (i.e., prompt_token_ids + output_token_ids) without the O(n) computation every time.

To make sure that the two lists are updated atomically, the PR introduces ConstantList. The constant list provides an immutable view of the list with O(1) overheads.

@WoosukKwon WoosukKwon requested a review from comaniac November 8, 2024 00:56
Copy link

github-actions bot commented Nov 8, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 8, 2024
@comaniac comaniac enabled auto-merge (squash) November 8, 2024 00:59
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

len is supported by ConstantList, but I fixed this for clarity.

Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@WoosukKwon WoosukKwon disabled auto-merge November 8, 2024 01:07
@WoosukKwon WoosukKwon merged commit 42b4f46 into main Nov 8, 2024
13 of 18 checks passed
@WoosukKwon WoosukKwon deleted the add-all-token-ids branch November 8, 2024 01:08
Isotr0py pushed a commit to Isotr0py/vllm that referenced this pull request Nov 8, 2024
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Isotr0py <2037008807@qq.com>
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Loc Huynh <jc1da.3011@gmail.com>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants