Skip to content

[doc] explain the class hierarchy in vLLM #10240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 12, 2024
Merged

[doc] explain the class hierarchy in vLLM #10240

merged 7 commits into from
Nov 12, 2024

Conversation

youkaichao
Copy link
Member

No description provided.

@youkaichao
add draft
a9907e2 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao
polish
7e9aaf1 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 12, 2024
@youkaichao
add doc
a35474e 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@DarkLight1337 DarkLight1337 self-assigned this Nov 12, 2024
@youkaichao
fix links
3f2ccab 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao
fix format
b88831a 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao
change image
416d064 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@DarkLight1337
Copy link
Member

Can we reorder the pages so that class hierarchy is at the top, then HF integration, and then the rest?

@youkaichao
re order
2af9513 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao
Copy link
Member Author

@DarkLight1337 sure, fixed.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 12, 2024 06:03
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 12, 2024
@youkaichao youkaichao disabled auto-merge November 12, 2024 06:56
@youkaichao youkaichao merged commit 3a28f18 into vllm-project:main Nov 12, 2024
39 of 41 checks passed
@youkaichao youkaichao deleted the explain_cls branch November 12, 2024 06:56
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@youkaichao @sumitd2
[doc] explain the class hierarchy in vLLM (vllm-project#10240)
120f1a9 
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@youkaichao
[doc] explain the class hierarchy in vLLM (vllm-project#10240)
3c61fd1 
Signed-off-by: youkaichao <youkaichao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

@DarkLight1337 DarkLight1337

Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youkaichao @DarkLight1337