Skip to content

[core][misc] keep compatibility for old-style classes #10356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2024
Merged

[core][misc] keep compatibility for old-style classes #10356

merged 2 commits into from
Nov 15, 2024

Conversation

youkaichao
Copy link
Member

#10304 will be too annoying for users. let's keep the compatibility for a while, and only give a warning first.

@youkaichao
keep compatibility
bb676e3 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

DarkLight1337
DarkLight1337 reviewed Nov 15, 2024
View reviewed changes
vllm/model_executor/model_loader/loader.py Outdated
# collect all kw-only parameters
kw_only_params = [
param.name for param in signatures.parameters.values()
if param.kind == inspect.Parameter.KEYWORD_ONLY
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we allow POSITIONAL_OR_KEYWORD arguments as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relaxed the constraint to only vllm_config and prefix . does it sound good to you?

@youkaichao
relax
3d86033 
Signed-off-by: youkaichao <youkaichao@gmail.com>
DarkLight1337
DarkLight1337 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for addressing my comment!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 15, 2024 08:16
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 15, 2024
@DarkLight1337 DarkLight1337 merged commit 3a763ba into vllm-project:main Nov 15, 2024
58 of 60 checks passed
@youkaichao youkaichao deleted the warn branch November 15, 2024 20:59
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@youkaichao
[core][misc] keep compatibility for old-style classes (vllm-project#1…
50e73f9 
…0356)

Signed-off-by: youkaichao <youkaichao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youkaichao @DarkLight1337