Skip to content

Conversation

rasmith
Copy link
Contributor

@rasmith rasmith commented Nov 16, 2024

When running a large model (~500G), I encountered GPU SEGV. It was occurring in fused_moe_kernel:

Thread 98 "python" received signal SIGSEGV, Segmentation fault.
Warning: precise memory violation signal reporting is not enabled, reported
location may not be accurate.  See "show amdgpu precise-memory".
[Switching to thread 98, lane 0 (AMDGPU Lane 7:2:1:1/0 (0,0,0)[0,0,0])]
fused_moe_kernel () at fused_moe.py:142
142             b = tl.load(b_ptrs,

It seemed to me that this could be integer overflow. Changing offsets to use tl.int64 in fused_moe.py:fused_moe_kernel fixes the issue.

NOTE: There was a previous PR, but it had DCO issues and I needed to recreate it.

Signed-off-by: Randall Smith <Randall.Smith@amd.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 16, 2024
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) November 16, 2024 03:24
@tlrmchlsmth tlrmchlsmth merged commit 1d75472 into vllm-project:main Nov 16, 2024
62 of 64 checks passed
prashantgupta24 pushed a commit to opendatahub-io/vllm that referenced this pull request Dec 3, 2024
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants