Skip to content

Conversation

bigPYJ1151
Copy link
Member

@bigPYJ1151 bigPYJ1151 commented Nov 27, 2024

The latest intel-omp will cause a segment fault on process exiting.

This PR fixed intel-omp version to avoid the problem.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Nov 27, 2024
Copy link
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@Isotr0py Isotr0py enabled auto-merge (squash) November 27, 2024 08:52
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 27, 2024
Signed-off-by: jiang1.li <jiang1.li@intel.com>
auto-merge was automatically disabled November 27, 2024 09:37

Head branch was pushed to by a user without write access

@Isotr0py Isotr0py enabled auto-merge (squash) November 27, 2024 11:20
@Isotr0py Isotr0py merged commit 418cb3b into vllm-project:main Nov 27, 2024
67 checks passed
@bigPYJ1151 bigPYJ1151 mentioned this pull request Nov 28, 2024
1 task
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
…-project#10700)

Signed-off-by: jiang1.li <jiang1.li@intel.com>
Signed-off-by: Andrew Feldman <afeldman@neuralmagic.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
anko-intel pushed a commit to HabanaAI/vllm-fork that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants