Skip to content

added support for quantize on LLM module #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 18, 2023
Merged

added support for quantize on LLM module #1080

merged 4 commits into from
Sep 18, 2023

Conversation

orellavie1212
Copy link
Contributor

No description provided.

@orellavie1212
Update llm.py
a4b4e81 
updating LLM to fix the problem
engine_args = EngineArgs(
TypeError: __init__() got an unexpected keyword argument 'quantization'
@orellavie1212
Update llm.py
51a6764 
updated the docstr of the class
@orellavie1212
Copy link
Contributor Author

fixing the problem arise via init (even if kwargs mentioned)
engine_args = EngineArgs(
TypeError: init() got an unexpected keyword argument 'quantization'

@WoosukKwon
Copy link
Collaborator

@orellavie1212 Thanks for the PR.

fixing the problem arise via init (even if kwargs mentioned)
engine_args = EngineArgs(
TypeError: init() got an unexpected keyword argument 'quantization'

Could you explain the problem in more detail? While I'm good with adding the quantization parameter to the LLM class for clarity, I believe it should already work. I've checked that llm = LLM(model="casperhansen/vicuna-7b-v1.5-awq", quantization="awq") just works.

@orellavie1212
Copy link
Contributor Author

orellavie1212 commented Sep 18, 2023 •
edited
Loading

I did exactly as you mentioned, I thought too, on python 3.9 (aws sagemaker) it doesn't work and quantize param didn't work, only after I made the change, it worked.
It could depend on the python version or other configuration, but to make it robust you could merge. The problem is mentioned on the first comment, this is exactly the bug.

WoosukKwon
WoosukKwon approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orellavie1212 LGTM! I made minor changes on the docstring. Thanks again for submitting the PR.

@WoosukKwon WoosukKwon merged commit fbe66e1 into vllm-project:main Sep 18, 2023
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
@orellavie1212
added support for quantize on LLM module (vllm-project#1080)
a44d0f8
minmin-intel pushed a commit to minmin-intel/vllm that referenced this pull request Jul 15, 2025
@PatrykWo @bartekkuncer
@MohitIntel @afierka-intel @AnetaKaczynska
[WIP] 1.21 docs update (vllm-project#1080)
b63079a 
It's the full list of changes in documentation prepared for the vLLM
1.21 release.

---------

Signed-off-by: Artur Fierka <artur.fierka@intel.com>
Co-authored-by: Bartosz Kuncer <bartosz.kuncer@intel.com>
Co-authored-by: Bartosz Kuncer <bkuncer@habana.ai>
Co-authored-by: Mohit Deopujari <mdeopujari@habana.ai>
Co-authored-by: Artur Fierka <artur.fierka@intel.com>
Co-authored-by: AnetaKaczynska <aneta.kaczynska@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoosukKwon WoosukKwon WoosukKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orellavie1212 @WoosukKwon