feat: support stop_token_ids parameter. #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuohan123
approved these changes
Sep 21, 2023
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
amy-why-3459
pushed a commit
to amy-why-3459/vllm
that referenced
this pull request
Sep 15, 2025
### What this PR does / why we need it? When profiling, it is often necessary to disable the call stack to reduce profiling overhead, and adjust the profiler_level to level1 to obtain more detailed operator and communication information. Therefore, it is recommended to modify the default profiling configuration. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No Signed-off-by: ApsarasX <apsarax@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the eos_token_ids is also special tokens it will be skip by default and generation won't stop correctly, so I think vLLM should support
stop_token_idslike FastChat does. But unlike FastChat,stop_strshould have higher priotity thanstop_token_idsbecause right now I only found this case, in other cases,stop_strworks well.Also check #792
Or else there are better solutions?