Skip to content

Conversation

youkaichao
Copy link
Member

fixes #11353

Signed-off-by: youkaichao <youkaichao@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 20, 2024
Copy link
Contributor

@Zerohertz Zerohertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related: #11353 (comment)

@youkaichao youkaichao merged commit 1ecc645 into vllm-project:main Dec 20, 2024
14 of 17 checks passed
@youkaichao youkaichao deleted the doc_compatibility branch December 20, 2024 05:33
mzusman pushed a commit to mzusman/vllm that referenced this pull request Mar 12, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants