Skip to content

mypy type checking for vllm/worker #11418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 23, 2024
Merged

mypy type checking for vllm/worker #11418

merged 3 commits into from
Dec 23, 2024

Conversation

lucas-tucker
Copy link
Contributor

@lucas-tucker lucas-tucker commented Dec 22, 2024 •
edited by github-actions bot
Loading

A few mypy type hints for vllm/worker

#3680

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

a couple mypy edits
4635a54 
Signed-off-by: lucast2021 <lucast2021@headroyce.org>
@DarkLight1337
Copy link
Member

Please fix the mypy errors.

fix yapf and mypy complaints
8e16873 
Signed-off-by: lucast2021 <lucast2021@headroyce.org>
@DarkLight1337
Copy link
Member

yapf is still failing.

yapf complaining
df3d0d2 
Signed-off-by: lucast2021 <lucast2021@headroyce.org>
DarkLight1337
DarkLight1337 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 23, 2024 06:38
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 23, 2024
@DarkLight1337 DarkLight1337 merged commit e51719a into vllm-project:main Dec 23, 2024
54 of 57 checks passed
mzusman pushed a commit to mzusman/vllm that referenced this pull request Mar 12, 2025
@lucas-tucker @mzusman
mypy type checking for vllm/worker (vllm-project#11418)
708f67e 
Signed-off-by: lucast2021 <lucast2021@headroyce.org>
Co-authored-by: lucast2021 <lucast2021@headroyce.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123 zhuohan123 is a code owner

@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucas-tucker @DarkLight1337