[FIX] Fix the case when input_is_parallel=False for ScaledActivation
#1737
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoosukKwon
approved these changes
Nov 21, 2023
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
jinyouzhi
pushed a commit
to jinyouzhi/vllm
that referenced
this pull request
Sep 12, 2025
…project#1737) ## Essential Elements of an Effective PR Description Checklist - [x] The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)". - [ ] The test plan, such as providing test command. - [ ] The test results, such as pasting the results comparison before and after, or e2e results ## Purpose Found current m_rope check is always call transformer API, which leads to a deeper python stack and longer CPU time Before: thinker_uses_mrope is called 33 times => leads to model_is_mrope spent 0.097ms. <img width="1682" height="573" alt="image" src="https://github.com/user-attachments/assets/f5de5586-8aa9-4028-b1ba-05b85dc6eaa1" /> With this PR: we removed thinker_uses_mrope call (only call once to set local property) => leads to model_is_mrope only spends 0.006ms <img width="1685" height="548" alt="image" src="https://github.com/user-attachments/assets/1b311199-e1a6-4dc5-b663-e2592fe18a57" /> ## Test Plan ## Test Result <!--- pyml disable-next-line no-emphasis-as-heading --> Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an error in #1731.