Add a flag to include stop string in output text #1976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks good! what's the variable name in TGI? How about placing it near the |
thanks for the review. TGI does not have this variable. it's default behavior is to include stop string in output. |
|
@WoosukKwon @zhuohan123 would you take a look? |
WoosukKwon
reviewed
Dec 14, 2023
There was a problem hiding this comment.
Hi @yunfeng-scale, thanks for submitting the PR! I think this makes sense. A friend of mine actually requested this 😂
Could you resolve the merge conflict and see my comment on the variable name? Thanks.
WoosukKwon
approved these changes
Dec 15, 2023
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Dec 18, 2023
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1973
tested by running server locally