Skip to content

Conversation

zhuohan123
Copy link
Member

@zhuohan123 zhuohan123 commented Jun 22, 2023

Fix #191.

@zhuohan123 zhuohan123 requested a review from WoosukKwon June 22, 2023 07:22
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhuohan123 zhuohan123 merged commit 1d24ccb into main Jun 22, 2023
@WoosukKwon WoosukKwon deleted the fix-oom-message branch June 22, 2023 08:01
michaelfeil pushed a commit to michaelfeil/vllm that referenced this pull request Jun 24, 2023
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
mht-sharma pushed a commit to mht-sharma/vllm that referenced this pull request Oct 30, 2024
wuhuikx pushed a commit to wuhuikx/vllm that referenced this pull request Mar 27, 2025
### What this PR does / why we need it?
Recover vllm-ascend dev image by soft revert:
-
vllm-project/vllm-ascend@701a287
-
vllm-project/vllm-ascend@aba0b83

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
wuhuikx pushed a commit to wuhuikx/vllm that referenced this pull request Mar 27, 2025
)

### What this PR does / why we need it?
remove v prefix in pip_vllm_version, followup on vllm-project#203

### Does this PR introduce _any_ user-facing change?
NO

### How was this patch tested?
```
$ grep "|pip_vllm_version|" -r ./docs/source
./docs/source/installation.md:pip install vllm==|pip_vllm_version|
```
preview
<img width="796" alt="image"
src="https://github.com/user-attachments/assets/516cef2e-9037-473a-8f04-baaaa260c1e3"
/>

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
dtrifiro pushed a commit to dtrifiro/vllm that referenced this pull request Apr 7, 2025
SUMMARY:

upstream sync to `bb103b29bf3d26fa831458a8ca5af1bb820c4712` this is as
of 2025-03-30 Boston AM.

```bash
> git log
commit f44d253 (HEAD -> upstreamsync-20250330, origin/upstreamsync-20250330)
Merge: 2602d9d bb103b2
Author: andy-neuma <andy@neuralmagic.com>
Date:   Sun Mar 30 11:17:52 2025 -0400

    Merge remote-tracking branch 'upstream/main'

commit bb103b2 (upstream/main)
Author: kYLe <kylhuang@nvidia.com>
Date:   Sun Mar 30 05:45:08 2025 -0500

    [Bugfix] Added `embed_is_patch` mask for fuyu model (vllm-project#15731)
    
    Signed-off-by: Kyle Huang <kylhuang@nvidia.com>
...
```

created via "merge" not cherry-pick

TEST PLAN:
accept sync is green -
https://github.com/neuralmagic/nm-cicd/actions/runs/14225725956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide proper error message when OOM happened during memory profiling
2 participants