Skip to content

[fix]: remove data type hardcoding from gptoss model implementation #23807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2025
Merged

[fix]: remove data type hardcoding from gptoss model implementation #23807

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfbf330
[fix]: remove data type hardcoding from gptoss model implementation
nikhil-arm Sep 17, 2025
0c244d5
Merge branch 'main' into gptoss_model_fix
nikhil-arm Sep 18, 2025
477d7bf
Merge branch 'main' into gptoss_model_fix
nikhil-arm Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions vllm/model_executor/models/gpt_oss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ def __init__(

self.sinks = torch.nn.Parameter(
torch.empty(config.num_attention_heads // tp_size,
dtype=torch.bfloat16,
requires_grad=False))

self.q_size = self.num_attention_heads * self.head_dim // tp_size
Expand Down Expand Up @@ -145,8 +144,7 @@ def __init__(
self.experts_per_token = config.num_experts_per_tok
self.world_size = dist.get_world_size() if dist.is_initialized() else 1
self.router = torch.nn.Linear(config.hidden_size,
config.num_local_experts,
dtype=torch.bfloat16)
config.num_local_experts)
assert config.intermediate_size % self.world_size == 0
self.experts = FusedMoE(num_experts=config.num_local_experts,
top_k=config.num_experts_per_tok,
Expand Down