[Doc] Add --force-overwrite option to generate_cmake_presets.py #24375
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a --force-overwrite option to the generate_cmake_presets.py script, allowing for non-interactive overwriting of existing CMakeUserPresets.json files. The implementation is straightforward and correct, using argparse to handle the new command-line flag. The logic correctly bypasses the user prompt when the flag is present, which is particularly useful for automated environments. The accompanying documentation in docs/contributing/incremental_build.md is also updated clearly and accurately to reflect this new functionality. The changes are well-contained and I found no issues.
elvischenv
force-pushed
the
elvischenv/improve-gen-cmake-script
branch
from
55122d1 to
acc432e
Compare
elvischenv
changed the title
|
cc @mgoin for review. Thanks! |
elvischenv
force-pushed
the
elvischenv/improve-gen-cmake-script
branch
from
acc432e to
ea8af50
Compare
Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
elvischenv
force-pushed
the
elvischenv/improve-gen-cmake-script
branch
from
ea8af50 to
2229c6c
Compare
|
@tlrmchlsmth / @LucasWilkinson could you take a look at this? It should be a quick review. |
…-project#24375) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com>
…-project#24375) Signed-off-by: elvischenv <219235043+elvischenv@users.noreply.github.com> Signed-off-by: charlifu <charlifu@amd.com>
Purpose
Add --force-overwrite option to generate_cmake_presets.py.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.