Skip to content

Conversation

minosfuture
Copy link
Contributor

@minosfuture minosfuture commented Sep 9, 2025

Purpose

Guard both hopper and blackwell support for DCP

Test Plan

local test CUDA_VISIBLE_DEVICES=0,1 pytest -v -s tests/distributed/test_context_parallel.py

Test Result

==================================================================================== warnings summary ====================================================================================
../../../../../home/yming/uv_env/vllm/lib64/python3.12/site-packages/schemathesis/generation/coverage.py:305
  /home/yming/uv_env/vllm/lib64/python3.12/site-packages/schemathesis/generation/coverage.py:305: DeprecationWarning: jsonschema.exceptions.RefResolutionError is deprecated as of version 4.18.0. If you wish to catch potential reference resolution errors, directly catch referencing.exceptions.Unresolvable.
    ref_error: type[Exception] = jsonschema.RefResolutionError,

tests/distributed/test_context_parallel.py::test_cp_generation[deepseek-ai/DeepSeek-V2-Lite-Chat-parallel_setup0-mp-1-auto-test_options0]
tests/distributed/test_context_parallel.py::test_cp_generation[deepseek-ai/DeepSeek-V2-Lite-Chat-parallel_setup1-mp-1-auto-test_options1]
tests/distributed/test_context_parallel.py::test_cp_generation[deepseek-ai/DeepSeek-V2-Lite-Chat-parallel_setup2-mp-1-auto-test_options2]
tests/distributed/test_context_parallel.py::test_cp_generation[deepseek-ai/DeepSeek-V2-Lite-Chat-parallel_setup3-mp-1-auto-test_options3]
  /data/users/yming/gitrepos/vllm/tests/utils.py:814: DeprecationWarning: This process (pid=1422877) is multi-threaded, use of fork() may lead to deadlocks in the child.
    pid = os.fork()

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================================================================= 4 passed, 5 warnings in 237.92s (0:03:57) ========================================================================

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Ming Yang <minos.future@gmail.com>
@mergify mergify bot added the ci/build label Sep 9, 2025
Signed-off-by: Ming Yang <minos.future@gmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds CI tests for Decode Context Parallelism (DCP) on Hopper and Blackwell architectures. The changes in the CI configuration and the test file are mostly correct and achieve this goal. I've found one potential issue in the test file that could make the test framework fragile for future changes and have suggested a fix.

[
params for model_id, settings in CP_TEXT_GENERATION_MODELS.items()
for params in settings.iter_params(model_id)
for setting in settings for params in setting.iter_params(model_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The list comprehension here assumes that the values in CP_TEXT_GENERATION_MODELS are always lists of CPTestSettings. This might be fragile if a new model is added with a single CPTestSettings object instead of a list. This would cause the test parameter generation to fail. To make this more robust, you could handle both cases by ensuring you're always iterating over a list.

Suggested change
for setting in settings for params in setting.iter_params(model_id)
for setting in (settings if isinstance(settings, list) else [settings]) for params in setting.iter_params(model_id)

Comment on lines 927 to 942
##### H200 test #####
- label: Qwen MoE EP Test # optional
gpu: h200
optional: true
num_gpus: 2
commands:
- CUDA_VISIBLE_DEVICES=1,2 VLLM_ALL2ALL_BACKEND=deepep_high_throughput VLLM_USE_DEEP_GEMM=1 VLLM_LOGGING_LEVEL=DEBUG python3 /vllm-workspace/examples/offline_inference/data_parallel.py --model Qwen/Qwen1.5-MoE-A2.7B --tp-size=1 --dp-size=2 --max-model-len 2048


- label: Hopper Decode Context Parallelism Test # optional
gpu: h200
optional: true
num_gpus: 2
commands:
- pytest -v -s tests/distributed/test_context_parallel.py

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge into one hopper distributed tests ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Ming Yang <minos.future@gmail.com>
@youkaichao youkaichao enabled auto-merge (squash) September 10, 2025 09:31
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 10, 2025
@simon-mo
Copy link
Collaborator

Can you check they actually run in CI by unblocking them?

Signed-off-by: Ming Yang <minos.future@gmail.com>
auto-merge was automatically disabled September 13, 2025 03:19

Head branch was pushed to by a user without write access

Signed-off-by: Ming Yang <minos.future@gmail.com>
@minosfuture
Copy link
Contributor Author

unblocked added CI tests and they've passed. But the existing qwen moe test has been failing. I can reproduce that locally. I wonder if this qwen moe test is never executed as part of CI.
I'll debug this once I have some cycles. Tracking the issue here: #24797.
@youkaichao @simon-mo is it ok to merge this PR in?

@youkaichao
Copy link
Member

sounds good, let's merge it first.

@youkaichao youkaichao merged commit 4e5affe into vllm-project:main Sep 16, 2025
72 of 76 checks passed
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
)

Signed-off-by: Ming Yang <minos.future@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants