[Misc][gpt-oss] Add gpt-oss label to PRs that mention harmony or related to builtin tool call #24717
Conversation
Signed-off-by: Chen Zhang <zhangch99@outlook.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the mergify configuration to automatically add the gpt-oss label to pull requests related to harmony or built-in tool calls. The changes are logical, but I've identified a related file that was missed. I've provided a suggestion to include it and also to make the configuration more concise.
| - files~=^vllm/entrypoints/harmony_utils.py | ||
| - files~=^vllm/entrypoints/tool_server.py | ||
| - files~=^vllm/entrypoints/tool.py | ||
| - title~=(?i)gpt[-_]?oss | ||
| - title~=(?i)harmony |
There was a problem hiding this comment.
To make this rule more comprehensive, I suggest adding vllm/reasoning/gptoss_reasoning_parser.py. This file is directly related to gpt-oss but is not covered by the existing or newly added rules.
Additionally, the two title conditions can be combined into a single regular expression for conciseness.
- files~=^vllm/entrypoints/harmony_utils.py
- files~=^vllm/entrypoints/tool_server.py
- files~=^vllm/entrypoints/tool.py
- files~=^vllm/reasoning/gptoss_reasoning_parser.py
- title~=(?i)(gpt[-_]?oss|harmony)Signed-off-by: Chen Zhang <zhangch99@outlook.com>
Signed-off-by: Chen Zhang <zhangch99@outlook.com>
| - files~=^vllm/entrypoints/harmony_utils.py | ||
| - files~=^vllm/entrypoints/tool_server.py | ||
| - files~=^vllm/entrypoints/tool.py | ||
| - files~=^vllm/entrypoints/context.py |
There was a problem hiding this comment.
lol maybe my bad, i named the test https://github.com/vllm-project/vllm/blob/main/tests/entrypoints/test_context.py
There was a problem hiding this comment.
good catch! I've added this file.
Signed-off-by: Chen Zhang <zhangch99@outlook.com>
…ted to builtin tool call (vllm-project#24717) Signed-off-by: Chen Zhang <zhangch99@outlook.com>
…ted to builtin tool call (vllm-project#24717) Signed-off-by: Chen Zhang <zhangch99@outlook.com>
…ted to builtin tool call (vllm-project#24717) Signed-off-by: Chen Zhang <zhangch99@outlook.com>
Purpose
Harmony parser and built-in tool call are only used by gpt-oss now. And some of these PRs don't mention gpt-oss. So I want to add a label to filter these PRs.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.