Reinstate existing torch script #24729
Merged
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
5 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reinstates a script to remove 'torch' from requirement files. The script correctly identifies and removes the lines, but the file modification is not atomic, which could lead to data loss if the script is interrupted. I've suggested a safer and more robust implementation that replaces the entire script logic.
zou3519
approved these changes
Sep 15, 2025
github-actions
bot
added
the
ready
zou3519
added a commit
to zou3519/vllm
that referenced
this pull request
Sep 15, 2025
The uv approach seems to only work when you exclusively use uv to manage your virtual environments (we have reports of it not working with conda envs). This PR is a followup to vllm-project#24729 and vllm-project#24303 Signed-off-by: Richard Zou <zou3519@gmail.com>
|
Doc fix over at #24892 |
tlrmchlsmth
pushed a commit
to tlrmchlsmth/vllm
that referenced
this pull request
Sep 15, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward fix to re-enable the old method before #24303