-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Remove redundant assignment in xfer_buffers, This is a little fix #24732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant assignment in xfer_buffers, This is a little fix #24732
Conversation
Signed-off-by: ChenTaoyu-SJTU <ctynb@qq.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes a redundant assignment to the xfer_buffers
variable in the register_kv_caches
method within nixl_connector.py
. The variable was already correctly assigned in a preceding if/else
block, making the subsequent assignment unnecessary. The change is correct and improves code clarity and maintainability by eliminating redundant code. I approve of this change.
@NickLucche This is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ChenTaoyu-SJTU
…lm-project#24732) Signed-off-by: ChenTaoyu-SJTU <ctynb@qq.com>
…lm-project#24732) Signed-off-by: ChenTaoyu-SJTU <ctynb@qq.com> Signed-off-by: bbartels <benjamin@bartels.dev>
…lm-project#24732) Signed-off-by: ChenTaoyu-SJTU <ctynb@qq.com>
Purpose
Remove the redundant assignment of
xfer_buffers
innixl_connector.py
. The before code already handle thexfer_buffers
in here:As can be seen above, the redundant assignment could be removed.
Test Plan
By pass CI
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.