-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Docs] Fix warnings in mkdocs build (continued) #24740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WARNING - griffe: vllm/model_executor/layers/quantization/torchao.py:175: No type or annotation for parameter 'torchao_config' WARNING - griffe: vllm/model_executor/layers/quantization/torchao.py:175: Parameter 'torchao_config' does not appear in the function signature WARNING - griffe: vllm/model_executor/layers/quantization/torchao.py:176: Failed to get 'name: description' pair from 'that encodes the type of quantization and all relevant arguments.' WARNING - griffe: vllm/model_executor/layers/quantization/torchao.py:149: Confusing indentation for continuation line 6 in docstring, should be 3 * 2 = 6 spaces, not 4 WARNING - griffe: vllm/model_executor/layers/quantization/torchao.py:147: No type or annotation for parameter '`param`' WARNING - griffe: vllm/model_executor/layers/quantization/torchao.py:147: Parameter '`param`' does not appear in the function signature WARNING - griffe: vllm/model_executor/layers/quantization/torchao.py:148: No type or annotation for parameter '`torchao_config`' WARNING - griffe: vllm/model_executor/layers/quantization/torchao.py:148: Parameter '`torchao_config`' does not appear in the function signature Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING - griffe: vllm/model_executor/layers/quantization/utils/int8_utils.py:426: No type or annotation for parameter 'output_dytpe' WARNING - griffe: vllm/model_executor/layers/quantization/utils/int8_utils.py:426: Parameter 'output_dytpe' does not appear in the function signature Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING - griffe: vllm/model_executor/layers/rotary_embedding/mrope.py:138: No type or annotation for parameter 'query' WARNING - griffe: vllm/model_executor/layers/rotary_embedding/mrope.py:138: Parameter 'query' does not appear in the function signature WARNING - griffe: vllm/model_executor/layers/rotary_embedding/mrope.py:139: No type or annotation for parameter 'key' WARNING - griffe: vllm/model_executor/layers/rotary_embedding/mrope.py:139: Parameter 'key' does not appear in the function signature Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING - griffe: vllm/model_executor/model_loader/tensorizer.py:178: No type or annotation for parameter 'tensorizer_uri' WARNING - griffe: vllm/model_executor/model_loader/tensorizer.py:184: No type or annotation for parameter 'tensorizer_dir' WARNING - griffe: vllm/model_executor/model_loader/tensorizer.py:189: No type or annotation for parameter 'vllm_tensorized' WARNING - griffe: vllm/model_executor/model_loader/tensorizer.py:196: No type or annotation for parameter 'verify_hash' WARNING - griffe: vllm/model_executor/model_loader/tensorizer.py:199: No type or annotation for parameter 'num_readers' WARNING - griffe: vllm/model_executor/model_loader/tensorizer.py:203: No type or annotation for parameter 'encryption_keyfile' WARNING - griffe: vllm/model_executor/model_loader/tensorizer.py:207: No type or annotation for parameter 's3_access_key_id' WARNING - griffe: vllm/model_executor/model_loader/tensorizer.py:209: No type or annotation for parameter 's3_secret_access_key' WARNING - griffe: vllm/model_executor/model_loader/tensorizer.py:211: No type or annotation for parameter 's3_endpoint' WARNING - griffe: vllm/model_executor/model_loader/tensorizer.py:213: No type or annotation for parameter 'lora_dir' Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING - griffe: vllm/model_executor/models/aria.py:145: Parameter 'patch_to_query_dict' does not appear in the function signature WARNING - griffe: vllm/model_executor/models/aria.py:146: Failed to get 'name: description' pair from 'query numbers,' WARNING - griffe: vllm/model_executor/models/aria.py:149: Parameter 'embed_dim' does not appear in the function signature WARNING - griffe: vllm/model_executor/models/aria.py:150: Parameter 'num_heads' does not appear in the function signature WARNING - griffe: vllm/model_executor/models/aria.py:151: Parameter 'kv_dim' does not appear in the function signature WARNING - griffe: vllm/model_executor/models/aria.py:152: Parameter 'ff_dim' does not appear in the function signature WARNING - griffe: vllm/model_executor/models/aria.py:153: Parameter 'output_dim' does not appear in the function signature WARNING - griffe: vllm/model_executor/models/aria.py:154: Parameter 'norm_layer' does not appear in the function signature WARNING - griffe: vllm/model_executor/models/aria.py:285: Failed to get 'name: description' pair from 'sequence_length, hidden_size).' Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING - griffe: vllm/model_executor/models/bart.py:665: Failed to get 'name: description' pair from 'decoder_input_ids' WARNING - griffe: vllm/model_executor/models/bart.py:669: Failed to get 'name: description' pair from 'decoder_positions' WARNING - griffe: vllm/model_executor/models/bart.py:492: Failed to get 'name: description' pair from 'decoder_hidden_states' WARNING - griffe: vllm/model_executor/models/bart.py:494: Failed to get 'name: description' pair from 'encoder_hidden_states' WARNING - griffe: vllm/model_executor/models/bart.py:586: Failed to get 'name: description' pair from 'input_ids' WARNING - griffe: vllm/model_executor/models/bart.py:590: Failed to get 'name: description' pair from 'positions' WARNING - griffe: vllm/model_executor/models/bart.py:403: Failed to get 'name: description' pair from 'hidden_states' WARNING - griffe: vllm/model_executor/models/bart.py:850: Failed to get 'name: description' pair from 'input_ids' WARNING - griffe: vllm/model_executor/models/bart.py:852: Failed to get 'name: description' pair from 'positions' WARNING - griffe: vllm/model_executor/models/bart.py:854: Failed to get 'name: description' pair from 'encoder_input_ids' WARNING - griffe: vllm/model_executor/models/bart.py:856: Failed to get 'name: description' pair from 'encoder_positions' WARNING - griffe: vllm/model_executor/models/bart.py:734: Failed to get 'name: description' pair from 'input_ids' WARNING - griffe: vllm/model_executor/models/bart.py:738: Failed to get 'name: description' pair from 'positions' WARNING - griffe: vllm/model_executor/models/bart.py:740: Failed to get 'name: description' pair from 'encoder_input_ids' WARNING - griffe: vllm/model_executor/models/bart.py:1118: Failed to get 'name: description' pair from 'decoder_input_ids' WARNING - griffe: vllm/model_executor/models/bart.py:1122: Failed to get 'name: description' pair from 'decoder_positions' WARNING - griffe: vllm/model_executor/models/bart.py:1037: Failed to get 'name: description' pair from 'input_ids' WARNING - griffe: vllm/model_executor/models/bart.py:1041: Failed to get 'name: description' pair from 'positions' WARNING - griffe: vllm/model_executor/models/bart.py:914: Failed to get 'name: description' pair from 'hidden_states' WARNING - griffe: vllm/model_executor/models/bart.py:1187: Failed to get 'name: description' pair from 'input_ids' WARNING - griffe: vllm/model_executor/models/bart.py:1191: Failed to get 'name: description' pair from 'positions' WARNING - griffe: vllm/model_executor/models/bart.py:1193: Failed to get 'name: description' pair from 'encoder_input_ids' Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING - griffe: vllm/model_executor/models/blip2.py:681: No type or annotation for parameter 'pixel_values' WARNING - griffe: vllm/model_executor/models/blip2.py:681: Parameter 'pixel_values' does not appear in the function signature Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING - griffe: vllm/model_executor/models/donut.py:353: Failed to get 'name: description' pair from 'input_ids' WARNING - griffe: vllm/model_executor/models/donut.py:355: Failed to get 'name: description' pair from 'positions' WARNING - griffe: vllm/model_executor/models/donut.py:357: Failed to get 'name: description' pair from 'encoder_input_ids' WARNING - griffe: vllm/model_executor/models/donut.py:359: Failed to get 'name: description' pair from 'encoder_positions' WARNING - griffe: vllm/model_executor/models/donut.py:81: Failed to get 'name: description' pair from 'input_ids' WARNING - griffe: vllm/model_executor/models/donut.py:83: Failed to get 'name: description' pair from 'positions' Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING - griffe: vllm/model_executor/models/florence2.py:1070: Failed to get 'name: description' pair from 'input_ids' WARNING - griffe: vllm/model_executor/models/florence2.py:1072: Failed to get 'name: description' pair from 'positions' WARNING - griffe: vllm/model_executor/models/florence2.py:1074: Failed to get 'name: description' pair from 'encoder_input_ids' WARNING - griffe: vllm/model_executor/models/florence2.py:1076: Failed to get 'name: description' pair from 'encoder_positions' WARNING - griffe: vllm/model_executor/models/florence2.py:701: Failed to get 'name: description' pair from 'input_ids' WARNING - griffe: vllm/model_executor/models/florence2.py:703: Failed to get 'name: description' pair from 'positions' WARNING - griffe: vllm/model_executor/models/florence2.py:705: Failed to get 'name: description' pair from 'encoder_input_ids' WARNING - griffe: vllm/model_executor/models/florence2.py:707: Failed to get 'name: description' pair from 'encoder_positions' WARNING - griffe: vllm/model_executor/models/florence2.py:633: Failed to get 'name: description' pair from 'input_ids' WARNING - griffe: vllm/model_executor/models/florence2.py:637: Failed to get 'name: description' pair from 'positions' WARNING - griffe: vllm/model_executor/models/florence2.py:639: Failed to get 'name: description' pair from 'encoder_input_ids' Signed-off-by: Zerohertz <ohg3417@gmail.com>
WARNING - griffe: vllm/model_executor/models/glm4_1v.py:1586: No type or annotation for parameter 'pixel_values' WARNING - griffe: vllm/model_executor/models/glm4_1v.py:1586: Parameter 'pixel_values' does not appear in the function signature WARNING - griffe: vllm/model_executor/models/glm4_1v.py:1588: No type or annotation for parameter 'image_grid_thw' WARNING - griffe: vllm/model_executor/models/glm4_1v.py:1588: Parameter 'image_grid_thw' does not appear in the function signature WARNING - griffe: vllm/model_executor/models/glm4_1v.py:1590: No type or annotation for parameter 'pixel_values_videos' WARNING - griffe: vllm/model_executor/models/glm4_1v.py:1590: Parameter 'pixel_values_videos' does not appear in the function signature WARNING - griffe: vllm/model_executor/models/glm4_1v.py:1592: No type or annotation for parameter 'video_grid_thw' WARNING - griffe: vllm/model_executor/models/glm4_1v.py:1592: Parameter 'video_grid_thw' does not appear in the function signature WARNING - griffe: vllm/model_executor/models/glm4_1v.py:1594: No type or annotation for parameter 'second_per_grid_ts' WARNING - griffe: vllm/model_executor/models/glm4_1v.py:1594: Parameter 'second_per_grid_ts' does not appear in the function signature Signed-off-by: Zerohertz <ohg3417@gmail.com>
hmellor
reviewed
Sep 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM just one nit about aria.py
hmellor
approved these changes
Sep 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Zerohertz
commented
Sep 12, 2025
Signed-off-by: Zerohertz <ohg3417@gmail.com>
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
Signed-off-by: Zerohertz <ohg3417@gmail.com>
MengqingCao
pushed a commit
to MengqingCao/vllm
that referenced
this pull request
Sep 13, 2025
Signed-off-by: Zerohertz <ohg3417@gmail.com>
dsxsteven
pushed a commit
to dsxsteven/vllm_splitPR
that referenced
this pull request
Sep 15, 2025
Signed-off-by: Zerohertz <ohg3417@gmail.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Zerohertz <ohg3417@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued #23649, #23743, #24092
Note
Warnings fixed: