-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Doc]: Remove 404 hyperlinks #24785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc]: Remove 404 hyperlinks #24785
Conversation
Signed-off-by: Rakesh Asapanna <45640029+rozeappletree@users.noreply.github.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix broken links in the examples documentation by removing them. While this resolves the 404 errors, it also removes useful navigation for users. A better approach would be to fix the link destinations, as the content for 'Offline Inference' and 'Online Serving' appears to exist elsewhere in the documentation, and the 'Others' section can link to the relevant examples directory. I've provided a suggestion to update the links accordingly.
Thanks, this approach seems good to me |
LGTM too! Manual ToC is a bit off a hangover from when we used Sphinx. Ideally we would not maintain any nav information in the page content like this. |
Signed-off-by: Rakesh Asapanna <45640029+rozeappletree@users.noreply.github.com>
Signed-off-by: Rakesh Asapanna <45640029+rozeappletree@users.noreply.github.com> Signed-off-by: bbartels <benjamin@bartels.dev>
Signed-off-by: Rakesh Asapanna <45640029+rozeappletree@users.noreply.github.com>
The hyperlinks in the examples page lead to 404 links (listed below):
two ways to go about this:
(or)
This PR takes approach 2 and removes the invalid links.