Skip to content

Conversation

rozeappletree
Copy link
Contributor

@rozeappletree rozeappletree commented Sep 12, 2025

The hyperlinks in the examples page lead to 404 links (listed below):

two ways to go about this:

  1. Either add a placeholder page with placeholder content until actual content is ready

(or)

  1. Remove the invalid links.

This PR takes approach 2 and removes the invalid links.

Signed-off-by: Rakesh Asapanna  <45640029+rozeappletree@users.noreply.github.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Sep 12, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix broken links in the examples documentation by removing them. While this resolves the 404 errors, it also removes useful navigation for users. A better approach would be to fix the link destinations, as the content for 'Offline Inference' and 'Online Serving' appears to exist elsewhere in the documentation, and the 'Others' section can link to the relevant examples directory. I've provided a suggestion to update the links accordingly.

@DarkLight1337
Copy link
Member

Thanks, this approach seems good to me

@vllm-bot vllm-bot merged commit 30498f2 into vllm-project:main Sep 13, 2025
17 of 18 checks passed
@hmellor
Copy link
Member

hmellor commented Sep 13, 2025

LGTM too! Manual ToC is a bit off a hangover from when we used Sphinx.

Ideally we would not maintain any nav information in the page content like this.

dsxsteven pushed a commit to dsxsteven/vllm_splitPR that referenced this pull request Sep 15, 2025
Signed-off-by: Rakesh Asapanna  <45640029+rozeappletree@users.noreply.github.com>
bbartels pushed a commit to bbartels/vllm that referenced this pull request Sep 15, 2025
Signed-off-by: Rakesh Asapanna  <45640029+rozeappletree@users.noreply.github.com>
Signed-off-by: bbartels <benjamin@bartels.dev>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: Rakesh Asapanna  <45640029+rozeappletree@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants