-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Force use C++17 globally to avoid compilation error #24823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
No ciflow labels are configured for this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly enforces the C++17 standard across the project by setting CMAKE_CXX_STANDARD
and CMAKE_CXX_STANDARD_REQUIRED
in the root CMakeLists.txt
. This is a good practice for ensuring build consistency. However, this change introduces a conflict with an existing per-target C++ standard setting, which could lead to maintenance issues in the future. I've added a comment with details on how to resolve this.
No ciflow labels are configured for this repo. |
No ciflow labels are configured for this repo. |
No ciflow labels are configured for this repo. |
Interestingly mergify bot and pytorch bot are battling here 🤣 |
Signed-off-by: chenfengjin <1871653365@qq.com>
No ciflow labels are configured for this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thanks for the contribution!
Signed-off-by: chenfengjin <1871653365@qq.com>
Signed-off-by: chenfengjin <1871653365@qq.com> Signed-off-by: bbartels <benjamin@bartels.dev>
Signed-off-by: chenfengjin <1871653365@qq.com>
Purpose
vLLM use some c++14/c++ 17 features, which may result in compilation error.
Force use 17 as default CXX version may reduce many confusing errors when build from source on some platforms that use C++ 11 as default CXX standard like MacOS apple silicon
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.