Skip to content

Conversation

windsonsea
Copy link
Contributor

@windsonsea windsonsea commented Sep 15, 2025

  • use steps in deploy section
  • add a command to prepare the vllm env
  • add alt text to image

@windsonsea windsonsea requested a review from hmellor as a code owner September 15, 2025 01:30
@mergify mergify bot added the documentation Improvements or additions to documentation label Sep 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the Streamlit integration documentation by adding explicit installation steps, restructuring the deployment guide into a numbered list, and improving image accessibility with alt text. My feedback focuses on further enhancing the clarity of the setup process by consolidating all dependency installations into a single step within the Prerequisites section. This change will create a more intuitive and error-resistant guide for users.

Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@vllm-bot vllm-bot merged commit 78818dd into vllm-project:main Sep 15, 2025
15 checks passed
dsxsteven pushed a commit to dsxsteven/vllm_splitPR that referenced this pull request Sep 15, 2025
)

Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
bbartels pushed a commit to bbartels/vllm that referenced this pull request Sep 15, 2025
)

Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
Signed-off-by: bbartels <benjamin@bartels.dev>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
)

Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants