Skip to content

Directly get max encoder len from VLLM config in V1 #24866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 16, 2025
Merged

Directly get max encoder len from VLLM config in V1 #24866

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0b4bc8d
Directly get max encoder len from VLLM config
Sugar-zsg Sep 15, 2025
5a5c11f
standardization
Sugar-zsg Sep 15, 2025
135fdd8
standardization
Sugar-zsg Sep 15, 2025
f319d51
without getattr
Sugar-zsg Sep 15, 2025
85a8854
standardization
Sugar-zsg Sep 15, 2025
d992f22
change to assert
Sugar-zsg Sep 15, 2025
a3ec262
Merge branch 'main' into whisper-v1-test
russellb Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions vllm/attention/layers/cross_attention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
from vllm.attention.selector import get_attn_backend
from vllm.config import CacheConfig, VllmConfig
from vllm.logger import init_logger
from vllm.multimodal import MULTIMODAL_REGISTRY
from vllm.utils import cdiv
from vllm.v1.attention.backends.utils import (CommonAttentionMetadata,
subclass_attention_backend)
Expand All @@ -23,9 +22,13 @@
logger = init_logger(__name__)


def _get_max_encoder_len(vllm_config: VllmConfig) -> int:
return MULTIMODAL_REGISTRY.get_encdec_max_encoder_len(
vllm_config.model_config)
def _get_max_encoder_len(vllm_config: "VllmConfig") -> int:
"""Gets the max number of encoder input tokens from the config.
"""
sc = vllm_config.scheduler_config
assert sc and isinstance(sc.max_num_encoder_input_tokens, int), \
"max_num_encoder_input_tokens must be int for enc-dec models"
return sc.max_num_encoder_input_tokens


def _get_cross_slot_mapping(encoder_seq_lens: np.ndarray,
Expand Down