[Misc] Own KVConnectors installation #24867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NickLucche <nlucches@redhat.com>
|
No ciflow labels are configured for this repo. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the .github/CODEOWNERS file to assign ownership of requirements/kv_connectors.txt to @NickLucche. This is a straightforward and correct configuration change that achieves the goal of notifying the appropriate developer about changes to KVConnector installation files. The implementation is sound, and I have no further feedback.
hmellor
approved these changes
Sep 15, 2025
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Sep 15, 2025
Signed-off-by: NickLucche <nlucches@redhat.com> Signed-off-by: bbartels <benjamin@bartels.dev>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: NickLucche <nlucches@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple way to get notified for KVConnector installation changes, without getting a lot of pings from all the build changes.