[ROCm] Add dependencies for ROCm #24900
Conversation
Concurrensee
force-pushed
the
amd_add_dependency
branch
from
bc03779 to
d5d4698
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds several dependencies to requirements/rocm-test.txt to support ROCm. The additions of tblib and timm align with the existing test dependencies. However, the introduction of lm-eval==0.4.9.1 creates an inconsistency with requirements/test.txt, which uses a different, git-based version of lm-eval. This could lead to divergent test behavior between ROCm and other platforms, which is a potential maintenance concern.
Concurrensee
force-pushed
the
amd_add_dependency
branch
2 times, most recently
from
28193bd to
7bbcb2c
Compare
requirements/rocm-test.txt
Outdated
There was a problem hiding this comment.
I believe this can be made a part of the global requirements, to be installed for production similar to https://github.com/vllm-project/vllm/blob/main/docker/Dockerfile#L524
From briefly looking through the uses, there seem to be a couple in the actual code, not just tests
Concurrensee
force-pushed
the
amd_add_dependency
branch
2 times, most recently
from
6a544bf to
81e390e
Compare
Signed-off-by: Yida Wu <yida.wu@amd.com>
Concurrensee
force-pushed
the
amd_add_dependency
branch
from
81e390e to
78b6c73
Compare
Signed-off-by: Yida Wu <yida.wu@amd.com>
Signed-off-by: Yida Wu <yida.wu@amd.com> Signed-off-by: charlifu <charlifu@amd.com>
Add dependencies for ROCm