Updated CODEOWNERS for flashinfer, mla, fused_moe #24906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mgoin <mgoin64@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the .github/CODEOWNERS file to assign ownership for several modules, including fused_moe, flashinfer, and mla. The changes correctly assign owners to new and existing file paths, which will help in directing future code reviews and maintenance. The modifications are syntactically correct and follow the standard format for CODEOWNERS files. I have reviewed the changes and have no comments or suggestions for improvement.
LucasWilkinson
approved these changes
Sep 16, 2025
github-actions
bot
added
the
ready
|
@mgoin Please see this PR. #24928 . Only people in the last match is tagged. will not tag Lucas for PRs only change /vllm/attention/backends/abstract.py . Is this the behavior you expect? |
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: mgoin <mgoin64@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.