[BugFix] Fix UB in per_token_group_quant.cu #24913
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The GroupReduceMax function causes Undefined Behavior. Existing mask specifies a half-warp causing UB for the upper 16 half of the threads in a warp.
Use threadIdx.x to select the correct mask at runtime.
This change follows a patch to SGLang for the same kernel.
Test Plan
Existing tests cover this kernel.
Test Result
Existing tests including CI should continue passing.
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.