-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[BUG] Allows for RunAI Streamer and Torch.compile cache to be used together #24922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ahao-anyscale <ahao@anyscale.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, asking for some quick stuf:
tests/test_config.py
Outdated
# Verify that the paths are deterministic based on the hash | ||
import hashlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this test since it's implementation dependent. Checking for the determinism through creating a config twice and seeing if the resulting paths match is the better test, which you are already doing.
tests/test_config.py
Outdated
|
||
# Verify that the directory names contain different hashes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove these specifics of hashing pattern from test as well.
vllm/config/__init__.py
Outdated
# Only download tokenizer if needed and not already handled | ||
if is_runai_obj_uri(tokenizer): | ||
object_storage_tokenizer = ObjectStorageModel() | ||
directory = hashlib.sha256(str(tokenizer).encode()).hexdigest()[:8] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create a util function for these hashing specifics that is shared between tokenizer and model?
Signed-off-by: ahao-anyscale <ahao@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: ahao-anyscale <ahao@anyscale.com>
…directory creation logic in tests Signed-off-by: ahao-anyscale <ahao@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor issues, otherwise LGTM
Signed-off-by: ahao-anyscale <ahao@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for addressing the comments, some final nits
Signed-off-by: ahao-anyscale <ahao@anyscale.com>
Signed-off-by: ahao-anyscale <ahao@anyscale.com>
3409d2d
to
45806a4
Compare
This pull request has merge conflicts that must be resolved before it can be |
@22quinn / @ProExpertProg could you please take a look at this PR from a model loader / torch compile perspective? |
Signed-off-by: ahao-anyscale <ahao@anyscale.com>
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM don't see anything of note w.r.t. compile cache
Signed-off-by: ahao-anyscale <ahao@anyscale.com>
Signed-off-by: ahao-anyscale <ahao@anyscale.com>
…gether (vllm-project#24922) Signed-off-by: ahao-anyscale <ahao@anyscale.com>
…gether (#24922) Signed-off-by: ahao-anyscale <ahao@anyscale.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
Purpose
Closes #24460
Test Plan
Unit tests in
vllm/tests/test_config.py
Test Result
Unit tests:
Terminal output when running vllm serve twice to generate and use cache:
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.