Skip to content

[Bugfix] Parse SpeculativeConfig Error #25142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2025
Merged

[Bugfix] Parse SpeculativeConfig Error #25142

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7983f0
fix: speculative-config-parse-error (#24888)
yyzxw Sep 18, 2025
9b510f5
Don't assume the dict will always have `method`
hmellor Sep 25, 2025
85576e6
Merge branch 'main' into fix/speculative-config-parse-error
hmellor Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions vllm/engine/arg_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1465,12 +1465,18 @@ def _is_v1_supported_oracle(self, model_config: ModelConfig) -> bool:
return False

# V1 supports N-gram, Medusa, and Eagle speculative decoding.
if (self.speculative_config is not None
and self.speculative_config.get("method") == "draft_model"):
raise NotImplementedError(
"Speculative decoding with draft model is not supported yet. "
"Please consider using other speculative decoding methods "
"such as ngram, medusa, eagle, or deepseek_mtp.")
if self.speculative_config is not None:
# speculative_config could still be a dict at this point
if isinstance(self.speculative_config, dict):
method = self.speculative_config.get("method", None)
else:
method = self.speculative_config.method

if method == "draft_model":
raise NotImplementedError(
"Draft model speculative decoding is not supported yet. "
"Please consider using other speculative decoding methods "
"such as ngram, medusa, eagle, or deepseek_mtp.")

V1_BACKENDS = [
"FLASH_ATTN_VLLM_V1",
Expand Down