Skip to content

Conversation

NickLucche
Copy link
Collaborator

Add a label for KVConnector related changes so it's easier to track, especially for OOT implementers looking for breaking interface changes.

Signed-off-by: NickLucche <nlucches@redhat.com>
@mergify mergify bot added the ci/build label Sep 18, 2025
@NickLucche
Copy link
Collaborator Author

cc @hmellor

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new Mergify rule to automatically label pull requests related to KVConnector. The new rule is a great addition for better tracking. I've identified a few areas where the file path matching conditions can be improved to be more comprehensive and ensure all relevant changes are captured. My feedback includes suggestions to broaden the scope of the matched paths.

Signed-off-by: NickLucche <nlucches@redhat.com>
@NickLucche
Copy link
Collaborator Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new Mergify rule to automatically label pull requests related to KVConnector. The logic for identifying relevant file paths seems correct. However, I've found a potential issue with one of the regular expressions for matching pull request titles, which could lead to many false positives. My suggestion aims to make the pattern more specific to avoid incorrect labeling.

Signed-off-by: NickLucche <nlucches@redhat.com>
@NickLucche
Copy link
Collaborator Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a Mergify rule to automatically label pull requests related to KVConnector. The file path and title-based conditions are a good start. I have a couple of suggestions to make the matching more robust and future-proof. Specifically, the regular expressions for matching file paths under disaggregated directories could be improved to handle different directory structures, and the title matching for P/D (Prefill/Decode) could be broadened to catch more variations.

Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: NickLucche <nlucches@redhat.com>
@NickLucche
Copy link
Collaborator Author

Thanks @hmellor !

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Feel free to action Gemini's comment if you want

Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: NickLucche <nlucches@redhat.com>
@NickLucche NickLucche enabled auto-merge (squash) September 18, 2025 13:07
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 18, 2025
@NickLucche NickLucche merged commit bc19d75 into vllm-project:main Sep 18, 2025
25 of 27 checks passed
debroy-rh pushed a commit to debroy-rh/vllm that referenced this pull request Sep 19, 2025
Signed-off-by: NickLucche <nlucches@redhat.com>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: NickLucche <nlucches@redhat.com>
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: NickLucche <nlucches@redhat.com>
Signed-off-by: charlifu <charlifu@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants