[Build] Update Xgrammar to 0.1.24 to get a CVE fix #25188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GHSA-9q5r-wfvf-rr7f Signed-off-by: Russell Bryant <rbryant@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the xgrammar dependency from version 0.1.23 to 0.1.24. This is a critical security fix to address a Regular Expression Denial of Service (ReDoS) vulnerability (GHSA-9q5r-wfvf-rr7f). The change is isolated to the requirements file and is the recommended action to patch the vulnerability. The change looks good to merge.
|
thanks for looking at this! I was trying to get it done via my companies process but happy to see it getting addressed quickly! I'll get the next one :D |
mgoin
approved these changes
Sep 18, 2025
github-actions
bot
added
the
ready
auto-merge was automatically disabled
September 19, 2025 00:11
Pull Request is not mergeable
debroy-rh
pushed a commit
to debroy-rh/vllm
that referenced
this pull request
Sep 19, 2025
Signed-off-by: Russell Bryant <rbryant@redhat.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Russell Bryant <rbryant@redhat.com>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: charlifu <charlifu@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GHSA-9q5r-wfvf-rr7f
Signed-off-by: Russell Bryant rbryant@redhat.com