[ROCm][Bugfix] Only enable +rms_norm based on aiter if not explicitly disabled #25275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a bug where an assertion would be thrown if rms_norm was explicitly disabled while VLLM_ROCM_USE_AITER was enabled. The fix correctly checks if '-rms_norm' is present before attempting to enable it. I've added one suggestion to further improve the robustness of this logic by also considering the 'none' flag in custom_ops to prevent overriding a user's intent to disable all custom operations.
ProExpertProg
approved these changes
Sep 24, 2025
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
… disabled (#25275) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #23412
If VLLM_ROCM_USE_AITER is enabled, and "-rms_norm" is explicitly set in the compilation config, an assertion is going to be thrown that an operation can't be both enabled and disabled.
Changing the enablement logic from the PR to respect explicit disablement.