[BUG FIX][NON-CUDA]quick fix to avoid call cudagraph_unsafe in attention #25298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a crash on non-CUDA platforms by conditionally including torch._C.Tag.cudagraph_unsafe. The approach is valid, but I've suggested a more robust implementation using a try-except block. This change would make the code more resilient by directly checking for the attribute's existence in the PyTorch library, rather than relying on vLLM's platform detection. I also recommend adding a regression test for non-CUDA environments to prevent this issue from recurring.
Signed-off-by: Chendi Xue <Chendi.Xue@intel.com>
|
@ProExpertProg , please help to review, thanks |
Signed-off-by: Chendi Xue <Chendi.Xue@intel.com>
bigPYJ1151
approved these changes
Sep 20, 2025
github-actions
bot
added
the
ready
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…ion (vllm-project#25298) Signed-off-by: Chendi Xue <Chendi.Xue@intel.com>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
…ion (vllm-project#25298) Signed-off-by: Chendi Xue <Chendi.Xue@intel.com> Signed-off-by: charlifu <charlifu@amd.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
…ion (#25298) Signed-off-by: Chendi Xue <Chendi.Xue@intel.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix failing for non cuda device when calling torch._C.Tag.cudagraph_unsafe
from #24281
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.