[V0 deprecation] Remove platform v1 controling interface #25410
Merged
+0
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Isotr0py
requested review from
NickLucche,
jikunshang and
bigPYJ1151
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the supports_v1 and default_v1 methods from the platform interfaces, aiming to clean up V0 deprecation-related code. The changes are consistent across the codebase, removing the method definitions and their usages. However, this change removes a safeguard that prevented V1 from being enabled on new or untested platforms. I've raised a critical concern about the potential for enabling V1 on incompatible platforms, which could lead to runtime issues. It's important to clarify whether V0 is fully removed, as this would dictate whether more V0-related fallback logic should be cleaned up, or if a new safeguard is needed.
WoosukKwon
approved these changes
Sep 23, 2025
linfeng-yuan
pushed a commit
to linfeng-yuan/vllm
that referenced
this pull request
Sep 23, 2025
…t#25410) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…t#25410) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
…t#25410) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: charlifu <charlifu@amd.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
supports_v1anddefault_v1to control v0 fallback at platform levelAlso cc @Yikun @xuechendi in case these interfaces are still used by plugins.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.