Skip to content

Conversation

chaunceyjiang
Copy link
Collaborator

@chaunceyjiang chaunceyjiang commented Sep 23, 2025

Purpose

v0.1.25 brings the structural tag. It also fixes a couple of problems regarding JSON schema and py.typed. It enhances the speed of grammar compilation and mask generation.

The new version of structural tags lays the foundation for refactoring the tool parser.
https://xgrammar.mlc.ai/docs/tutorials/structural_tag.html#example-1-tool-calling

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the xgrammar dependency to version 0.1.25 and adapts the codebase to the new API. The changes in vllm/v1/structured_output/backend_xgrammar.py correctly use xgr.StructuralTag.from_legacy_structural_tag to create a StructuralTag object, which is now required by the updated library functions. The changes are straightforward, necessary for the version bump, and appear correct. I have no further comments.

@russellb russellb enabled auto-merge (squash) September 23, 2025 13:28
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 23, 2025
@russellb russellb merged commit 08275ec into vllm-project:main Sep 23, 2025
93 of 94 checks passed
yma11 pushed a commit to yma11/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Sep 26, 2025
)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Co-authored-by: Chauncey <chaunceyjiang@gmail.com>
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed structured-output v1
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants